Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polyRAD #94

Merged
merged 57 commits into from
Feb 12, 2025
Merged

Add polyRAD #94

merged 57 commits into from
Feb 12, 2025

Conversation

alex-sandercock
Copy link
Collaborator

  • Updated UI to select polyRAD or Updog
  • Added in two new functions to wrap the polyRAD processes:
    • These are in the DosageCall_functions R file
    • polyRAD_dosage_call performs the actual dosage calling to obtain discrete genotypes
    • polyRAD2vcf adds those genotypes and HindHe to the original vcf

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The new make_vcf_format() function within the polyrad2vcf is different than how it is implemented in dosage2vcf and updog2vcf. This is much faster than the previous formats, and does not rely on reshape2.
    • Check that those other versions correctly concatenate the FORMAT information from the different dataframes

Copy link
Collaborator Author

@alex-sandercock alex-sandercock Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the error when getting dosage_ratios() for the boxplot, I am not sure why that happens in the Genotype Diversity tab. I was not able to identify any obvious formatting errors here that were different than previous VCF formats and could be impacting how the dosage calls are viewed. Note: All of the modules rely on converting the GT field to discrete dosage calls, so the issue could be in how that field is formatted, not the UD field.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I removed the ability to select for the _LD options for now until we do more testing and allow for users to select more custom options

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not get the download button to be disabled (or not be present ), until the analysis completes. WIll need to update the UI if not already adjusted in other pull requests.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added support for svg(), and will need to extend this to all image downloading functions

@alex-sandercock alex-sandercock added the enhancement New feature or request label Feb 6, 2025
@Cristianetaniguti
Copy link
Collaborator

I had to solve some conflicts between previous pull and this one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Updog, the dosage calls are usually based on the count of reference alleles, where 0 = homozygous alternate. I am assuming that DArT using the standard Updog parameters, so it is likely also that count

@alex-sandercock alex-sandercock merged commit fcdd74f into development Feb 12, 2025
4 checks passed
@alex-sandercock alex-sandercock deleted the svg_add branch February 12, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants